Skip to content

chore(infobox): change type name for player infobox - #8030

Open
ElectricalBoy wants to merge 4 commits into
mainfrom
rename-infobox-person-type
Open

chore(infobox): change type name for player infobox#8030
ElectricalBoy wants to merge 4 commits into
mainfrom
rename-infobox-person-type

Conversation

@ElectricalBoy

Copy link
Copy Markdown
Collaborator

Summary

The base player infobox was given the type name of Person - this is problematic for several reasons:

  • all infobox type names include Infobox (consistency)
  • Person could be misunderstood as parsed wikicode input (e.g., from {{Person}})

Thus, this PR renames Person type to InfoboxPerson for more clarity.

How did you test this change?

trivial

@hjpalpha hjpalpha left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm modulo linter/ls issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants