feat: Exclude showmatches in Team/Player infobox achievements - #8021
Open
mbergen wants to merge 1 commit into
Open
feat: Exclude showmatches in Team/Player infobox achievements#8021mbergen wants to merge 1 commit into
mbergen wants to merge 1 commit into
Conversation
mbergen
commented
Aug 28, 2026
| local MAX_PARTY_SIZE = 4 | ||
| local DEFAULT_BASE_CONDITIONS = { | ||
| ConditionUtil.noneOf(ColumnName('liquipediatiertype'), {'Qualifier', 'Charity'}), | ||
| ConditionUtil.noneOf(ColumnName('liquipediatiertype'), {'Qualifier', 'Charity', 'Showmatch'}), |
Collaborator
Author
There was a problem hiding this comment.
Could even consider to exclude all tiertypes here.
hjpalpha
approved these changes
Aug 28, 2026
ElectricalBoy
approved these changes
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
per title. Could also override this on AoE where it was noticed, but i think this is a better default than before.
How did you test this change?