Repository navigation
CI enforces what the docs scripts only offered - #10
Merged
Merged
Conversation
checks.yml gains two jobs. docs-current runs scripts/render-docs.py in check mode, so the rendered counts and version markers can no longer drift silently — the script existed but nothing ran it. tokens-sync runs the new scripts/check-tokens.py, which resolves every var() chain in lib/tokens.css (light, then dark cascaded on top) and compares the result against the literals in lib/tokens.js: 38 primitives, 41 light and 41 dark color values. The last audit hand-checked those 82 matches; now the machine does. Two pointers still named globals.css, which has been a two-line import shim since the tokens/base split: the PR template told contributors to add tokens there (CONTRIBUTING already said tokens.css), and the tokens.js header claimed to mirror it. Both now say lib/tokens.css, as does the token-purity job's error message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
checks.ymlgains two jobs:docs-currentrunsscripts/render-docs.pyin check mode (the stale-docs check existed but nothing ran it), andtokens-syncruns the newscripts/check-tokens.py, which resolves everyvar()chain inlib/tokens.css(light:root, then the dark overrides cascaded on top) and compares the results against the literals inlib/tokens.js— 38 primitives, 41 light and 41 dark color values. The last audit hand-checked those matches; now CI does.Also fixes three pointers that still named
globals.css, a two-line import shim since the tokens/base split: the PR template's token checklist line (CONTRIBUTING already saidtokens.css), thetokens.jsheader, and the token-purity job's error message.No version bump, no changelog entry — same treatment as the last post-release doc fix.
Type
Checklist
lib/components.css(the CI check passes)lib/tokens.cssfor both light and dark (n/a — no new values)data-theme="dark") — the sync check verifies both themesCHANGELOG.md(SemVer) — intentionally not: process/CI change, no shipped-library change; matches the precedent of the post-v1.6 fix commitScreenshots (light + dark)
n/a — no rendered output changes. Verification instead:
render-docs.pyandcheck-tokens.pyboth pass on this branch;check-tokens.pywas negative-tested against a mutated JS literal and a mutated CSS primitive (the latter correctly flagged both--brandand--accentin dark via the alias chain).🤖 Generated with Claude Code
https://claude.ai/code/session_01WmahEexkaJcf2iUFJHbKna
Generated by Claude Code