Repository navigation
Restore renamed PrefetchedDocumentLoader fields as deprecated aliases - #179
Merged
Merged
Conversation
Bumping @rubensworks/eslint-config renamed the public static fields CJS_MAJOR_VERSION, CONTEXT_URL and CONTEXT_PATTERN to camelCase, which breaks dependents that still use the old names. For example, componentsjs-generator 4.2.0 reads PrefetchedDocumentLoader.CONTEXT_URL, so it now generates contexts with null instead of the Components.js context URL, after which no config that uses those contexts can be loaded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UeSuG8npLjD7EpaYC6LCWE
The test ended as soon as the unknown import failed, while the slow import was still being parsed, so it was parsed after the Jest environment had been torn down. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UeSuG8npLjD7EpaYC6LCWE
Coverage Report for CI Build 42389418008Coverage remained the same at 100.0%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a4d841d (bumping
@rubensworks/eslint-configto 3.1.0) renamed three public static fields ofPrefetchedDocumentLoaderto camelCase:CJS_MAJOR_VERSIONcjsMajorVersionCONTEXT_URLcontextUrlCONTEXT_PATTERNcontextPatternThis hasn't been released yet, but it would break dependents that use the old names.
componentsjs-generator4.2.0 readsPrefetchedDocumentLoader.CONTEXT_URL, so with the current master it getsundefinedand generatescomponents/context.jsonldfiles that start withnullinstead of the Components.js context URL. Every component file that uses such a context then fails to load with errors likeInvalid predicate IRI: requireName. I ran into this when installing master into Comunica: no engine config could be compiled anymore.This adds the old names back as deprecated aliases of the new ones, so this can be released as a minor version. These three fields are the only public members that a4d841d renamed; the other renames are private fields and generic type parameters.
It also fixes a test from #178 that ended while one of its imports was still being parsed, which made Jest report an import after its environment was torn down. The test now waits for that import to end.
Verification
yarn lint,yarn buildandyarn test:jest(872 tests, 100% coverage) pass.Generated by Claude Code