fix: add void return type to LimeniusLiformBundle::build() for Symfony 8 - #47
Open
francis-roux-serret wants to merge 1 commit into
Open
francis-roux-serret wants to merge 1 commit into
francis-roux-serret wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Tag
2.1bumpedcomposer.jsonto declare Symfony^8.0support, but the code change for it wasn't included. On Symfony 8,Symfony\Component\HttpKernel\Bundle\Bundle::build()is typed as: void, so the current signature inLimeniusLiformBundle::build()triggers a fatal compile error when the kernel initializes bundles:Reproduced on a Symfony 8 / PHP 8.5 project by installing
limenius/liform-bundle:^2.1and runningbin/console cache:clear.Fix
Add
: voidtoLimeniusLiformBundle::build(). This is compatible with Symfony 5.4/6/7 as well (the parent has been: voidsince Symfony 4.4).Notes
This is the last remaining piece of Symfony 8 support after #. Nothing else needs to change.