test: improve unit tests coverage for AccountService (Infection) - #8142
Open
diogopaz wants to merge 1 commit into
Open
test: improve unit tests coverage for AccountService (Infection)#8142diogopaz wants to merge 1 commit into
diogopaz wants to merge 1 commit into
Conversation
Signed-off-by: Diogo Paz <diogoachiles@gmail.com>
|
Thanks for opening your first pull request in this repository! ✌️ |
Member
|
@diogopaz the problems in the unit tests aren't caused by your PR. I'll fix this in a separate PR. But have linter issues that you need to solve: https://github.com/LibreSign/libresign/actions/runs/33325571740/job/100018743935?pr=8142 |
Member
|
Once you fix the linter issue and push the changes, the unit tests will work fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #8053
📝 Summary
This PR adds extensive PHPUnit test coverage to
AccountServiceTestto eliminate escaped mutants and improve the mutation testing score with Infection, as part of #8053.🧪 How to test
Run the focused unit test suite for AccountService:
Optionally run Infection on this specific pair to verify mutant coverage:
⚙️ API / Back‑end changes
validateCreateToSign,getFileByUuid,createToSign,saveVisibleElement(s),uploadPfx,updatePfxPassword,readPfxData, and config fallbacks.✅ Checklist
🤖 AI (if applicable)