riscv: avoid FMA error recovery for directed fmadd.s - #315
Open
carlosqwqqwq wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
riscv: avoid FMA error recovery for directed fmadd.s
Fixes #309
Commit message
Description
The
fpu_fma32error-recovery calculation is exact only for RNE. For directed modes it can cross an f32 grid point and under-reportUF. Apply the f32-specific single-rounding path, preserve the NX raised by the preceding f64 sum, and discard only the later TwoSum flags that are not guest-visible. The change is limited tosrc/util/fpu_lib.h; validation artifacts stay out of the source diff.Validation
The patch is independently applicable to the
stagingbranch. Its scope isfinite
fmadd.sdirected rounding under RTZ/RDN/RUP; other FMA root causesremain outside this patch.