riscv: use exact rounding for tiny directed FMA results - #314
Open
carlosqwqqwq wants to merge 1 commit into
Open
riscv: use exact rounding for tiny directed FMA results#314carlosqwqqwq wants to merge 1 commit into
carlosqwqqwq wants to merge 1 commit into
Conversation
carlosqwqqwq
force-pushed
the
fix/fma-tiny-directed
branch
2 times, most recently
from
September 6, 2026 05:37
541927d to
a4ffb6a
Compare
carlosqwqqwq
force-pushed
the
fix/fma-tiny-directed
branch
from
September 6, 2026 05:59
a4ffb6a to
832d3d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
riscv: use exact rounding for tiny directed FMA results
Fixes #308
Commit message
Description
The directed-rounding FMA path can double-round a subnormal product and
its error term, producing a wrong result and false
UF. Use one 128-bit exactrounding path for the affected
fmadd.drange under RTZ/RDN/RUP, and restoreNX/UF from the exact result. The change is limited to
src/util/fpu_lib.h;validation artifacts stay out of the source diff. This patch applies independently
to the
stagingbranch and does not depend on an unmerged FMA change.Validation
The patch is independently applicable to the
stagingbranch. RNE/RMM tinyresults remain outside this patch's scope.