riscv: keep tiny FMA RNE/RMM results on the host rounded path - #313
Open
carlosqwqqwq wants to merge 1 commit into
Open
riscv: keep tiny FMA RNE/RMM results on the host rounded path#313carlosqwqqwq wants to merge 1 commit into
carlosqwqqwq wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
riscv: keep tiny FMA RNE/RMM results on the host rounded path
Fixes #307
Commit message
Description
For very small
fmadd.dresults, the software error term issubnormalised and the odd-round correction moves an already correctly
rounded host result by one ulp (and leaks a spurious
UF). Under RNE/RMM,return the host result only when the product and addend do not undergo severe
cancellation; retain the exact-recovery path for that cancellation boundary.
The retained severe-cancellation boundary and directed modes remain outside this
patch's scope. The change is limited to
src/util/fpu_lib.h; validation artifactsstay out of the source diff. This patch applies independently to the
stagingbranch and does not depend on an unmerged FMA change.
Validation
The patch is independently applicable to the
stagingbranch. Its scope is thenon-cancelling RNE/RMM tiny-result path in
fpu_fma64_raw.