fpu: canonicalize sqrt NaN results - #301
Open
carlosqwqqwq wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fpu: canonicalize sqrt NaN results
Fixes #292
Commit message
Description
The
fsqrt.sandfsqrt.dwrappers test the sign before classifying NaNs. Positive qNaNs therefore return their payload unchanged, and signaling NaNs do not consistently raiseNV. Handle NaNs first, canonicalize both precisions, and raise invalid only when the input is signaling. The existing negative finite-input and signed-zero behavior remains unchanged.Validation
NVfor signaling NaNs; the patched build matches on the single- and double-precision witness matrix.