Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two things on every template's Run it locally page were wrong.
coveragestage, but it's calledresults, sodocker build . --target coveragefails. Theteststage also saves the exit code instead of failing, so the page now says to checkout/exit-code. Without that, a pipeline built on these stages stays green when a test fails.dotnet runparagraph gave the HTTPS address twice. The address that redirects is the HTTP one: 7310, 7320, 7330 or 7340.We checked both against the Dockerfile and
launchSettings.jsonin the templates.Related issues
None. These are small corrections found while reviewing the docs.
Checklist