Skip to content

fix(cd): list the .deb assets explicitly so the gui shim is not packaged - #521

Merged
LargeModGames merged 1 commit into
mainfrom
fix/deb-assets
Sep 8, 2026
Merged

fix(cd): list the .deb assets explicitly so the gui shim is not packaged#521
LargeModGames merged 1 commit into
mainfrom
fix/deb-assets

Conversation

@LargeModGames

@LargeModGames LargeModGames commented Sep 8, 2026

Copy link
Copy Markdown
Owner

Summary

The v0.42.0 release run failed on both Linux builds at the Package Debian (.deb) step:

error: Unable to read asset to add to archive: .../target/x86_64-unknown-linux-gnu/release/spotatui-gui
  cause: No such file or directory (os error 2)

cargo-deb packages every [[bin]] by default, and the spotatui-gui shim from #462 only builds with the gui feature, so the release build never produces it. [package.metadata.deb] now lists its assets explicitly: the spotatui binary and the README. The .deb step has not passed since #462; the two previous release runs failed earlier, at the crates.io publish.

Testing

  • cargo metadata --locked passes (no lockfile change)
  • cargo build --release --no-default-features --features telemetry,tui, then cargo deb --no-build with the new table: the package holds usr/bin/spotatui, usr/share/doc/spotatui/README and copyright, with Suggests: yt-dlp, ffmpeg intact
  • Not verified locally: dpkg-shlibdeps (Arch has no dpkg), so the local package has an empty Depends:. The failed CI job shows it running on the Ubuntu runner, so the released package gets the real dependencies

Additional notes

After merge the v0.42.0 tag is moved to the merge commit and pushed again. The failed run published nothing (no release object, no crates.io upload), so there is nothing to clean up.

The package's long description is the whole README because cargo-deb defaults extended-description to it. Pre-existing, left alone here.

Summary by CodeRabbit

  • Bug Fixes
    • Debian packages now install the spotatui executable correctly with appropriate permissions.
    • Package documentation now includes the README in the standard system documentation location.
    • Packaging is more consistent across standard and GUI build configurations.

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: d235a3fd-6587-4977-a4c0-fecedcf2851d

📥 Commits

Reviewing files that changed from the base of the PR and between 17338e7 and e4655ab.

📒 Files selected for processing (1)
  • Cargo.toml

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The Debian package metadata now explicitly installs the spotatui release binary and README.md with defined destinations and file modes. This prevents cargo-deb from packaging the GUI binary when it is unavailable.

Changes

Debian packaging

Layer / File(s) Summary
Explicit Debian asset manifest
Cargo.toml
The [package.metadata.deb] section installs target/release/spotatui to usr/bin/ with mode 755 and README.md to usr/share/doc/spotatui/README with mode 644.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to e4655

The Debian package now includes only the CLI binary and README, preventing the unavailable GUI shim from being packaged. The defined paths and permissions match the intended package contents, with no remaining merge-readiness risk identified.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title uses the permitted conventional-commit prefix fix(cd):, clearly describes the Debian asset-listing fix, and uses a concise imperative subject.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/deb-assets
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/deb-assets

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@LargeModGames
LargeModGames merged commit 21e9a54 into main Sep 8, 2026
32 checks passed
@LargeModGames
LargeModGames deleted the fix/deb-assets branch September 8, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant