fix(cd): list the .deb assets explicitly so the gui shim is not packaged - #521
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe Debian package metadata now explicitly installs the ChangesDebian packaging
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The Debian package now includes only the CLI binary and README, preventing the unavailable GUI shim from being packaged. The defined paths and permissions match the intended package contents, with no remaining merge-readiness risk identified. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Summary
The v0.42.0 release run failed on both Linux builds at the
Package Debian (.deb)step:cargo-deb packages every
[[bin]]by default, and thespotatui-guishim from #462 only builds with theguifeature, so the release build never produces it.[package.metadata.deb]now lists its assets explicitly: thespotatuibinary and the README. The.debstep has not passed since #462; the two previous release runs failed earlier, at the crates.io publish.Testing
cargo metadata --lockedpasses (no lockfile change)cargo build --release --no-default-features --features telemetry,tui, thencargo deb --no-buildwith the new table: the package holdsusr/bin/spotatui,usr/share/doc/spotatui/READMEandcopyright, withSuggests: yt-dlp, ffmpegintactdpkg-shlibdeps(Arch has no dpkg), so the local package has an emptyDepends:. The failed CI job shows it running on the Ubuntu runner, so the released package gets the real dependenciesAdditional notes
After merge the
v0.42.0tag is moved to the merge commit and pushed again. The failed run published nothing (no release object, no crates.io upload), so there is nothing to clean up.The package's long description is the whole README because cargo-deb defaults
extended-descriptionto it. Pre-existing, left alone here.Summary by CodeRabbit
spotatuiexecutable correctly with appropriate permissions.