Fix fieldKey encoding for CustomizeView column picker - #3148
Open
labkey-tchad wants to merge 2 commits into
Open
Fix fieldKey encoding for CustomizeView column picker#3148labkey-tchad wants to merge 2 commits into
labkey-tchad wants to merge 2 commits into
Conversation
labkey-danield
approved these changes
Aug 10, 2026
DariaBod
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
The customize view column picker has unusual encoding for the
data-recordIdattribute. The Java URLEncoder we're trying to use doesn't encode the same set of characters covered by the JavaScriptencodeURImethod. There's no good Java equivalent without adding imports. We can just call the same method through WebDriver.Related Pull Requests
Changes