Skip to content

SqlFragment no longer implements CharSequence #1296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-matthewb merged 2 commits into from
Oct 16, 2026
Merged

SqlFragment no longer implements CharSequence #1296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbd8dab
Remove "implements Appendable, CharSequence" from SQLFragment
labkey-matthewb Oct 15, 2026
f3f3021
address more implicit casts SQLFragment->CharSequence
labkey-matthewb Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/org/labkey/targetedms/query/GeneralMoleculePrecursorChromatogramsTableInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ private static TableInfo getPivotByPrecursorChromInfoTable(Container container,
{
sb.append(qe.getMessage()).append('\n');
}
throw new IllegalStateException(sb + "\n.SQL: " + sql);
throw new IllegalStateException(sb + "\n.SQL: " + sql.toDebugString());
}

return tableInfo;
Expand Down
3 changes: 2 additions & 1 deletion src/org/labkey/targetedms/query/TargetedMSTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,8 @@ public SQLFragment getFromSQL(String alias)
// See issue 38134 - don't filter if we don't need to because we're on the other side of a FK/lookup
if ((getContainerFilter() != ContainerFilter.getUnsafeEverythingFilter() && !(getContainerFilter() instanceof TargetedMSForeignKey.AnnotationsContainerFilter)) || _containerTableFilter != null)
{
sql.append(_joinType != null ? _joinType.getSQL() : "");
if (_joinType != null)
sql.append(_joinType.getSQL());

sql.append(" WHERE ");
sql.append(getContainerFilter().getSQLFragment(getSchema(), _containerSQL));
Expand Down
Loading