Repository navigation
Fix TargetedMS chromatogram, QC plot, and QC summary exceptions reported to mothership - #1294
Merged
Merged
Conversation
Handle small-molecule transition/index count mismatches, duplicate molecule series labels, sample files not found in the current container, QC folders with no enabled metrics, replicate annotation filters in the precursor pivot query, and runs deleted while their import finishes.
ankurjuneja
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This PR fixes a batch of TargetedMS exceptions reported to mothership across chromatogram rendering, Skyline import, QC outlier calculation, and the QC plot/summary pages. Two of the fixes also correct wrong behavior rather than just suppressing the error: the replicate annotation filter on the peptide/molecule chromatogram grid never worked, and small-molecule precursor chromatograms could map transitions to the wrong traces when a transition filter was active.
Triage notes for these mothership reports: https://claude.ai/artifact/CtxKZANKRqfhZxs7PHEqBr
Changes
Tasks