Repository navigation
Extend QC summary loading wait for slow first-load metric caching - #1290
Merged
Merged
Conversation
labkey-danield
approved these changes
Oct 7, 2026
labkey-danield
left a comment
labkey-danield
left a comment
Contributor
There was a problem hiding this comment.
As a test fix I'm fine with this, as long as we ok with the product behavior.
Contributor
Author
|
The other option is to fill the cache at the end of import job, that could move the slow loading of page during the first load. |
Contributor
|
If this fixes the failure I think it's fine to focus on making TC happy with this approach. I don't think this particular timing pattern is a real-world problem. |
Contributor
Author
|
The test passed in TC, I will trigger a few more runs to ensure it passes consistently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
The first QC page load after an import computes every precursor's metric values before either panel can render and on TC this often takes more than 15s, so adding wait up to 60s for verifyQcSummary .
Related Pull Requests
Changes