[bot] Merge 26.7 to 26.8 - #979
Open
github-actions[bot] wants to merge 4 commits into
Open
Conversation
## Rationale The `_SND Attribute Data` ETL fails on every run that includes a delete at SNPRC with `java.lang.ClassCastException: class java.lang.Long cannot be cast to class java.lang.Integer`. exp 25.005 widened `exp.Object.ObjectId` and `exp.ObjectProperty.ObjectId` to BIGINT, but `AttributeDataTable.UpdateService.deleteRows` still cast the delete key to `Integer`. `TransformTask` builds each delete key from the target table's PK columns, which for this table are `exp.ObjectProperty`'s `ObjectId` and `PropertyId`, so the first row aborts the step. ## Changes - `AttributeDataTable.UpdateService.deleteRows` casts `ObjectId` and `PropertyId` to `Number` rather than `Integer`. - `EventDataTable` declares its injected `exp.Object.ObjectId` column as `JdbcType.BIGINT` instead of `JdbcType.INTEGER`, matching the widened column.
…976) * Drop redundant unique index on snprc_ehr.labwork_services.ServiceId * Bump snprc_ehr schema version 26.001 -> 26.002
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated automatically.
Merging changes from: 1b035c6
Approve all matching PRs simultaneously.
Approval will trigger automatic merge.
Verify all PRs before approving: https://internal.labkey.com/Scrumtime/Backlog/harvest-gitOpenPullRequests.view?branch=26.8_fb_bot_merge_26.7