Skip to content

Remove references to the retired MergeSync module - #977

Open
labkey-martyp wants to merge 1 commit into
release26.3-SNAPSHOTfrom
26.3_fb_remove_mergesync_ogasync
Open

Remove references to the retired MergeSync module#977
labkey-martyp wants to merge 1 commit into
release26.3-SNAPSHOTfrom
26.3_fb_remove_mergesync_ogasync

Conversation

@labkey-martyp

Copy link
Copy Markdown
Contributor

Rationale

Removes this module's last references to MergeSync, which is being retired. The labwork request form they belonged to is not registered, so none of this code was reachable at runtime.

Related Pull Requests

Changes

  • Removes the Merge integration from the labwork request form, along with its instructions panel.
  • Drops the prompt that offered to open Merge after a request was submitted.

LabworkRequestFormType declared a client dependency on MergeSync; ClientDependency.supplierFromModuleName throws IllegalArgumentException when the named module is absent. The registration for this form type is commented out in SNPRC_EHRModule, so the failure was latent rather than live.

LabworkRequestDataEntryPanel no longer offers to open Merge after a commit, and LabworkRequestInstructionsFormSection is removed along with its instructions panel, which rendered Merge links and nothing else.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants