Repository navigation
Fix intermittent failure in ContainerManager testMissesNotCachedInTransaction - #8271
Merged
labkey-adam merged 3 commits intoNov 3, 2026
Merged
Conversation
…nsaction Background search work queued when the test container is created can look up its EntityId after the delete and legitimately cache the miss, so the test now looks up an unused GUID.
…1_fb_container_miss_test_race
labkey-jeckels
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Fix an intermittent failure in
ContainerManager$TestCase.testMissesNotCachedInTransaction. The test asserted that the deleted container's EntityId had no cached miss after an in-transaction lookup, but search indexing work queued when the container was created can look up that EntityId on another thread after the delete commits and correctly cache the miss.Related Pull Requests
Changes