Repository navigation
Log the slow suppliers (dev mode) and catch exceptions - #8269
Merged
Merged
Conversation
…low usage metrics suppliers
labkey-jeckels
approved these changes
Nov 1, 2026
labkey-jeckels
left a comment
Contributor
There was a problem hiding this comment.
This seems fine but also not really that necessary. In typical operations the server calculates metrics once a day in a background thread, so shifting to a maintenance task is OK but not a win in terms of total work.
Contributor
Author
Agreed, for production deployments. This is more about speeding it up for local testing and development (e.g., when adding new metrics). This reduced metrics generation locally from a somewhat annoying ~30 seconds to ~3 seconds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Wrap all usage metrics supplier dereferences with a helper method that:
Introduce
NightlyRecalculatingSuppliers, which provides caching suppliers that persist and recalculate nightly. Use them to speed up five slow usage metrics suppliers.Related Pull Requests