Skip to content

GH Issue 1756: Tolerate orphaned provisioned storage in nightly maintenance tasks - #8266

Merged
labkey-adam merged 3 commits into
developfrom
fb_special_char_missing_tables_1756
Nov 1, 2026
Merged

labkey-adam merged 3 commits into
developfrom
fb_special_char_missing_tables_1756

Conversation

@labkey-adam

@labkey-adam labkey-adam commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Rationale

Stop nightly system maintenance tasks from failing or logging ERRORs when domain metadata outlives its provisioned storage. The special character metrics task fails with SQLState 42P01 on every run for tables whose physical table or column is gone (specimen, study dataset, assay result, ELISpot, NAb, sample type), triggering nightly alerts across many hosts. The missing files check aborts entirely when a domain's provisioned schema belongs to a module that's no longer deployed. Cleaning up the orphans themselves is tracked separately in GH Issue 1612.

Fixes GH Issue 1756.

Related Pull Requests

  • None

Changes

  • Special character metrics task scans only tables and columns the database catalog confirms exist
  • Log any remaining per-table scan failure at WARN instead of ERROR
  • Missing files check skips provisioned schemas no deployed module claims and tables that no longer exist
  • Add a test that a sample type with a missing physical table is skipped
  • Migrate the special character metrics task off deprecated SQLFragment methods

…etrics task

Scan only tables and columns the catalog confirms exist, so orphaned domain metadata no longer logs ERRORs nightly. Also migrate the task off deprecated SQLFragment methods.
@labkey-adam
labkey-adam requested a review from XingY October 31, 2026 15:28
@labkey-adam labkey-adam self-assigned this Oct 31, 2026
@labkey-adam labkey-adam added this to the 26.11 milestone Oct 31, 2026
…ener

Domains can outlive the module that provisioned them, which made the nightly missing files check fail.
@labkey-adam labkey-adam changed the title GH Issue 1756: Skip missing provisioned tables in special character metrics task GH Issue 1756: Tolerate orphaned provisioned storage in nightly maintenance tasks Oct 31, 2026
@labkey-adam
labkey-adam merged commit e2ebfa2 into develop Nov 1, 2026
10 checks passed
@labkey-adam
labkey-adam deleted the fb_special_char_missing_tables_1756 branch November 1, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants