Repository navigation
Test UsageMetrics inconsistent descriptions in production mode too - #8251
Merged
Merged
Conversation
labkey-danield
approved these changes
Oct 28, 2026
XingY
pushed a commit
that referenced
this pull request
Oct 29, 2026
…8251) ## Rationale Fixes the `UsageMetrics$TestCase.testRepeatedDescriptions` failure in production-mode suites, which expected an exception that is only thrown in dev mode. First failed in https://teamcity.labkey.org/buildConfiguration/LabKey_Trunk_Premium_DistributionSuites_ProductionCommunityPostgres/4238610 ## Changes - Expect an exception for inconsistent descriptions only in dev mode; in production mode, verify the first description is kept and the value is still recorded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Fixes the
UsageMetrics$TestCase.testRepeatedDescriptionsfailure in production-mode suites, which expected an exception that is only thrown in dev mode. First failed in https://teamcity.labkey.org/buildConfiguration/LabKey_Trunk_Premium_DistributionSuites_ProductionCommunityPostgres/4238610Changes