Repository navigation
Fix duplicate createRoot warning - #8249
Merged
Merged
Conversation
labkey-alan
marked this pull request as ready for review
October 28, 2026 18:03
cnathe
approved these changes
Oct 28, 2026
cnathe
left a comment
cnathe
left a comment
Contributor
There was a problem hiding this comment.
and manual testing done. looks good
XingY
pushed a commit
that referenced
this pull request
Oct 29, 2026
- `ProductNavigation/app.tsx`: only call createRoot once - `ProductNavigationHeader.js`: use bootstrap events to toggle menu show state - `header.jsp`: default the header dropdown content as loading
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This PR fixes the warning that React emits about createRoot being used on the same element multiple times as observed by @labkey-adam. The problem is that calling
loadApptriggers theonInitcallback passed toApp.registerAppfrom@labkey/api, and we were calling this every time the user hovered over the product navigation icon or clicked outside of the icon when the menu is open.Related Pull Requests
Changes
ProductNavigation/app.tsx: only call createRoot onceProductNavigationHeader.js: use bootstrap events to toggle menu show stateheader.jsp: default the header dropdown content as loadingTasks