Skip to content

GH Issue 1707: Keep the primary file's audit event in the import transaction when a transform runs first - #8225

Closed
labkey-jeckels wants to merge 1 commit into
developfrom
fb_transform_file_audit_1707
Closed

labkey-jeckels wants to merge 1 commit into
developfrom
fb_transform_file_audit_1707

Conversation

@labkey-jeckels

Copy link
Copy Markdown
Contributor

Rationale

Fixes a regression from #8183: when an assay design has a transform script, the primary data file's file audit event was recorded outside the import transaction, so it no longer carried the transaction ID. The primary file is now saved while the transform is prepared, before the transaction opens, which broke BiologicsAssayFilesTest.testImportAssayWithFileFieldData (TeamCity failure). See GH Issue 1707.

Related Pull Requests

Changes

  • File audit events for files saved while preparing a transform are held and recorded once the import transaction opens, so they carry its transaction ID as before
  • Imports without a transform script, and background imports, are unchanged

Tasks

  • Claude Code Review
  • Manual Testing
  • Test Automation

@labkey-jeckels

Copy link
Copy Markdown
Contributor Author

Closing in favor of #8220, which now includes this fix: audit events for files saved before a transform script runs are held on the prepared transform and recorded in the import transaction, and a failed import records them only for files it keeps.

@labkey-jeckels
labkey-jeckels deleted the fb_transform_file_audit_1707 branch October 24, 2026 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant