Repository navigation
GH Issue 1707: Keep the primary file's audit event in the import transaction when a transform runs first - #8225
Closed
labkey-jeckels wants to merge 1 commit into
Closed
labkey-jeckels wants to merge 1 commit into
labkey-jeckels wants to merge 1 commit into
Conversation
…saction when a transform runs first
Contributor
Author
|
Closing in favor of #8220, which now includes this fix: audit events for files saved before a transform script runs are held on the prepared transform and recorded in the import transaction, and a failed import records them only for files it keeps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Fixes a regression from #8183: when an assay design has a transform script, the primary data file's file audit event was recorded outside the import transaction, so it no longer carried the transaction ID. The primary file is now saved while the transform is prepared, before the transaction opens, which broke
BiologicsAssayFilesTest.testImportAssayWithFileFieldData(TeamCity failure). See GH Issue 1707.Related Pull Requests
Changes
Tasks