[bot] Merge 26.7 to 26.8 - #7926
Open
github-actions[bot] wants to merge 9 commits into
Open
Conversation
## Rationale Claude-code is good at writing reports that run locally in an IDE. There are idiosyncrasies with converting a running r/python/knitr report to run within LabKey. This resource helps with that. Also, limit/offset as port of sql-execute.api ## Related Pull Requests - <!-- list of links to related pull requests (replace this comment) --> ## Changes - <!-- list of descriptions of changes that are worth noting (replace this comment) --> <!-- list of standard tasks (remove this comment to enable) ## Tasks 📍 - [ ] Claude Code Review - [ ] Manual Testing - [ ] Test Automation - [ ] Verify Fix -->
## Rationale We want to have a better handle on how long scripts are taking to execute. ## Changes - `DEBUG` level logging for starting a script - `INFO` or higher for completion depending on result - Let script invokers provide context about their usage ## Tasks 📍 - [x] Claude Code Review @labkey-jeckels - [x] Manual Testing - not needed - [x] Test Automation
## Rationale We should configure `SchemaFactory` centrally like other XML objects so that we get the right settings consistently. ## Changes - Utility/factory method to get a configured `SchemaFactory` with external references disabled ## Tasks 📍 - [x] Claude Code Review - ~Manual Testing~ - ~Test Automation~
#7919) ## Rationale We're leaking a DB connection (eventually cleaned up on garbage collection) when DataIterator construction bails out due to a problem like duplicate or unwanted columns. ## Changes - Helper `wrapOrClose()` method to centralize closing when we bail out on a handled or unhandled error - Convert `DataIterator` implementations to use helper - Automated tests
…ion (#7920) ## Rationale Cross Folder Dependencies in the schema browser is an easy way to DOS when using HTTP2, which essentially fires requests for every subfolder concurrently. We need to throttle this and can also improve the UX significantly. ## Changes - Limit the client side to 4 concurrent analysis requests - New `ConcurrencyLimit` annotation to limit the number of concurrent requests on the server-side - Cap `AnalyzeQueriesAction` to 10 concurrent requests - Filter domains *before* creating the `DomainImpl` - Default to project-scoped analysis - Show number of folders to be analyzed - Give a cancel option - Show all errors during analysis - Always show the Dependency Report, even when there are no dependencies to show - Show the scope that was analyzed in the Dependency Report
## Rationale We've long been inconsistent in terms of how we handle case-sensitive file extension checks when they have a trailing `.gz` ## Changes - Standardize behavior between `isType()`, `isMatch()`, etc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated automatically.
Merging changes from: 43c9abe
Approve all matching PRs simultaneously.
Approval will trigger automatic merge.
Verify all PRs before approving: https://internal.labkey.com/Scrumtime/Backlog/harvest-gitOpenPullRequests.view?branch=26.8_fb_bot_merge_26.7