Skip to content

Dedupe calls of ExecutingSqlSelector large collections - #7917

Open
labkey-jeckels wants to merge 4 commits into
developfrom
fb_cacheWarningDedupe
Open

Dedupe calls of ExecutingSqlSelector large collections#7917
labkey-jeckels wants to merge 4 commits into
developfrom
fb_cacheWarningDedupe

Conversation

@labkey-jeckels

@labkey-jeckels labkey-jeckels commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Rationale

Our new WARN logging for ExecutingSqlSelector calls that return large collections is working. However, it's logging multiple callers of the same problematic code when they originate from different call sites.

Changes

  • Throttle based on the top of the call stack, not the whole thing
  • Also log the type of object being returned in the collection

Tasks

  • Claude Code Review
  • Manual Testing @cnathe 📍
  • Test Automation

@labkey-jeckels
labkey-jeckels requested a review from cnathe August 8, 2026 00:13
@labkey-jeckels labkey-jeckels self-assigned this Aug 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants