Skip to content

Update ChatModal buttons to improve accessibility #2104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-micahs merged 5 commits into from
Oct 28, 2026
Merged

Update ChatModal buttons to improve accessibility #2104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
66cdf98
Add aria-labels for button on ChatModal
labkey-micahs Oct 26, 2026
6251800
Merge branch 'develop' into fb_chat_a11y_1556
labkey-micahs Oct 26, 2026
3ebf7ff
Correct spelling issues and capture version bump
labkey-micahs Oct 26, 2026
455d24b
@labkey/components@7.74.1-fb-chat-a11y-1556.1
labkey-micahs Oct 26, 2026
f03368c
Bump version to 7.74.1
labkey-micahs Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/components/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@labkey/components",
"version": "7.74.0",
"version": "7.74.1",
"description": "Components, models, actions, and utility functions for LabKey applications and pages",
"sideEffects": false,
"files": [
Expand Down
4 changes: 2 additions & 2 deletions packages/components/src/internal/components/mcp/ChatModal.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ describe('ChatModal', () => {

// Act
await user.type(getTextarea(), ' hello world ');
await user.click(screen.getByRole('button', { name: '' }).closest('.btn') as HTMLElement);
await user.click(screen.getByRole('button', { name: 'Submit' }));
Comment thread
labkey-micahs marked this conversation as resolved.
Resolved

// Assert - sendPrompt receives the trimmed value once and the textarea is reset
expect(sendPrompt).toHaveBeenCalledTimes(1);
Expand Down Expand Up @@ -217,7 +217,7 @@ describe('ChatModal', () => {
expect(document.querySelector('.chat-item.pending')).toBeInTheDocument();
expect(sendPrompt).not.toHaveBeenCalled();

const stopBtn = document.querySelector('.prompt-button') as HTMLButtonElement;
const stopBtn = screen.getByRole('button', { name: 'Stop' });
expect(stopBtn.querySelector('.fa-stop')).toBeInTheDocument();
fireEvent.click(stopBtn);
expect(onInterrupt).toHaveBeenCalledTimes(1);
Expand Down
14 changes: 12 additions & 2 deletions packages/components/src/internal/components/mcp/ChatModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,12 +175,22 @@ export const ChatModal: FC<ChatModalProps> = memo(props => {
</div>
</div>
{isPending && (
<button className="btn btn-default prompt-button" onClick={handleInterrupt} type="button">
<button
aria-label="Stop"
className="btn btn-default prompt-button"
onClick={handleInterrupt}
type="button"
>
<i className="fa fa-stop" />
</button>
)}
{!isPending && (
<button className="btn btn-default prompt-button" disabled={!prompt.trim()} type="submit">
<button
aria-label="Submit"
className="btn btn-default prompt-button"
disabled={!prompt.trim()}
type="submit"
>
<i className="fa fa-arrow-up" />
</button>
)}
Expand Down
Loading