GitHub Issue 1409: When creating Molecules, show the other entities that will be created automatically - #2050
Open
XingY wants to merge 5 commits into
Open
GitHub Issue 1409: When creating Molecules, show the other entities that will be created automatically#2050XingY wants to merge 5 commits into
XingY wants to merge 5 commits into
Conversation
labkey-nicka
approved these changes
Aug 10, 2026
|
|
||
| const typeNameRows: Record<string, any[]> = {}; | ||
| const dataRows = await selectRows({ | ||
| schemaQuery: SCHEMAS.EXP_TABLES.DATA, |
Contributor
There was a problem hiding this comment.
Consider specifying .detailView
| dataRows.rows.forEach(row => { | ||
| const dataClass = caseInsensitive(row, 'DataClass/Name')?.value; | ||
| const rowId = caseInsensitive(row, 'RowId').value; | ||
| if (!typeNameRows[dataClass]) |
Contributor
There was a problem hiding this comment.
Avoid caching undefined as a key value.
dataRows.rows.forEach(row => {
const dataClass = caseInsensitive(row, 'DataClass/Name')?.value;
if (dataClass) {
const rowId = caseInsensitive(row, 'RowId').value;
if (!typeNameRows[dataClass])
typeNameRows[dataClass] = [];
typeNameRows[dataClass].push({ rowId });
}
});
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Related Pull Requests
Changes