Skip to content

Describe the EHR participant history filter client-side metric - #1232

Merged
labkey-jeckels merged 2 commits into
developfrom
fb_metric_descriptions
Oct 28, 2026
Merged

labkey-jeckels merged 2 commits into
developfrom
fb_metric_descriptions

Conversation

@labkey-jeckels

@labkey-jeckels labkey-jeckels commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

@labkey-jeckels labkey-jeckels self-assigned this Oct 25, 2026
@labkey-jeckels
labkey-jeckels marked this pull request as ready for review October 25, 2026 22:17

@labkey-bpatel labkey-bpatel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but please review my comment.

@Override
protected void doStartupAfterSpringConfig(ModuleContext moduleContext)
{
SimpleMetricsService.get().describeClientSideFeatureArea("ehrParticipantHistoryFilter", "Participant history filter use, by filter type: aliveAtCenter or all when a user switches to that filter, idSearch for each completed ID lookup, including ones that match no IDs");

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested rewording : "Participant History filter usage by type: Alive at Center, All, or completed ID search, including searches with no matching IDs"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong preference about how these are captured, but aliveAtCenter and idSearch are the terms that will actually show up in metric names, so it seemed useful to capture them in a way that helps guide querying more directly. Let me know if that makes sense to you, or if you still prefer the suggested wording.

labkey-jeckels added a commit to LabKey/platform that referenced this pull request Oct 28, 2026
## Rationale
Documents what every usage metric reports to mothership, so each value
can be understood without reading the code that produces it.

The provider API changes, so the other `fb_metric_descriptions` PRs must
merge with this one.

[GH Issue 1775](LabKey/internal-issues#1775)

## Related Pull Requests
- LabKey/limsModules#2564
- LabKey/premiumModules#821
- LabKey/commonAssays#1094
- LabKey/customModules#289
- LabKey/targetedms#1298
- LabKey/ehrModules#1232

## Changes
- Every usage metrics provider reports a description with each value;
the separate described-provider interface is merged into the base one.
- Metrics reported only on some servers can be described without being
reported.
- Simple metric feature areas have fixed names and descriptions,
including the client-side areas counted by `@labkey/components`.
- Descriptions for the metrics of platform modules.
labkey-jeckels added a commit to LabKey/commonAssays that referenced this pull request Oct 28, 2026
## Rationale
Describes the Flow and Protein usage metrics, using the API added in the
platform PR.

[GH Issue 1775](LabKey/internal-issues#1775)

## Related Pull Requests
- LabKey/platform#8228
- LabKey/limsModules#2564
- LabKey/premiumModules#821
- LabKey/customModules#289
- LabKey/targetedms#1298
- LabKey/ehrModules#1232

## Changes
- Descriptions for Flow's and Protein's usage metrics.
labkey-jeckels added a commit to LabKey/customModules that referenced this pull request Oct 28, 2026
## Rationale
Describes the Specimen usage metrics, using the API added in the
platform PR.

[GH Issue 1775](LabKey/internal-issues#1775)

## Related Pull Requests
- LabKey/platform#8228
- LabKey/limsModules#2564
- LabKey/premiumModules#821
- LabKey/commonAssays#1094
- LabKey/targetedms#1298
- LabKey/ehrModules#1232

## Changes
- Descriptions for Specimen's usage metrics.
@labkey-jeckels
labkey-jeckels merged commit c21f50a into develop Oct 28, 2026
10 of 12 checks passed
@labkey-jeckels
labkey-jeckels deleted the fb_metric_descriptions branch October 28, 2026 00:55
labkey-jeckels added a commit to LabKey/targetedms that referenced this pull request Oct 28, 2026
## Rationale
Describes the TargetedMS usage metrics, using the API added in the
platform PR.

[GH Issue 1775](LabKey/internal-issues#1775)

## Related Pull Requests
- LabKey/platform#8228
- LabKey/limsModules#2564
- LabKey/premiumModules#821
- LabKey/commonAssays#1094
- LabKey/customModules#289
- LabKey/ehrModules#1232

## Changes
- Descriptions for TargetedMS's usage metrics.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants