Add manifest.properties COPY layer for kanban #2018 - #193
Open
labkey-willm wants to merge 2 commits into
Open
Conversation
Lays 48_manifest.properties alongside the existing distribution properties file so the LimsStarterContainer build can layer in the upstream-generated ModuleLoader.include manifest without disturbing per-distribution properties. Placeholder committed at repo root so other distributions keep building; the sibling TeamCity test build will populate it from the SNAPSHOT Installers artifact. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…ifest.properties
Removes startup/{allpg,community,enterprise,lims_starter}.properties since prod deployments always overwrite them anyway, and they'd drifted (lims_starter.properties had a ModuleLoader.exclude line silently ignored due to a missing ;startup modifier) — only basic.properties remains.
Moves manifest.properties into startup/ alongside basic.properties for consistency, and drops the now-dead COPY "startup/${LABKEY_DISTRIBUTION}.properties" layer from the Dockerfile since there's no longer a source file for it.
Bumps quickstart_envs.sh's LABKEY_VERSION to 26.9-SNAPSHOT to match current local testing.
labkey-gokhano
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
48_manifest.propertiesCOPY layer (before the existing distribution properties file) so the build can consume the upstream-generatedModuleLoader.includemanifest artifact fromLabKey_Trunk_Premium_Installers(e.g.LabKey<version>-lims_starter.properties, sitting next to the distribution tar.gz).manifest.propertiesintostartup/, alongsidebasic.properties, for consistency — it's populated at build time the same way.startup/{allpg,community,enterprise,lims_starter}.propertiesand theCOPY "startup/${LABKEY_DISTRIBUTION}.properties"layer that consumed them: prod deployments always overwrite these anyway, andlims_starter.propertieshad drifted (aModuleLoader.excludeline silently ignored due to a missing;startupmodifier).Part of https://github.com/LabKey/kanban/issues/2018 (Unify LIMS cloud distributions - dev/test).
Test plan
LimsStarterContainerManifestTestKanban2018, run add mailhog #1) on this branch: artifact fetched, manifest renamed/staged, image built, smoke test passed.startup/manifest.propertiespath and the simplifiedstartup/dir — image builds clean, container reaches healthy.LimsStarterContainerNightlybuild updated with the same artifact-dependency/step changes; will validate on next real nightly run post-merge.🤖 Generated with Claude Code