Skip to content

Resolve SequenceAnalysis pipeline paths through PipeRoot - #450

Merged
labkey-matthewb merged 1 commit into
developfrom
fb_docker_tar
Oct 29, 2026
Merged

labkey-matthewb merged 1 commit into
developfrom
fb_docker_tar

Conversation

@labkey-matthewb

Copy link
Copy Markdown

Rationale

Keep SequenceAnalysis readset validation and reference sequence import working with LabKey/platform#8227, which no longer accepts a multi-segment path string passed as a single Path part.

Related Pull Requests

Changes

  • Resolve posted directory paths through the pipeline root instead of wrapping the raw string in a single-part Path.
  • Report a path that can't be resolved as a validation error rather than a NullPointerException.
  • Return each file's path relative to the pipeline root that actually contains it, so files under a supplemental root can be imported.
  • Fall back to the directory and file name when the posted relative path is null or empty.

new Path(form.getPath()) treats a multi-segment path as one name, which platform fb_docker_tar now rejects; also handles supplemental roots and missing paths.

@bbimber bbimber left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as long as the tests pass this should be fine

@labkey-matthewb
labkey-matthewb merged commit a226747 into develop Oct 29, 2026
8 of 9 checks passed
@labkey-matthewb
labkey-matthewb deleted the fb_docker_tar branch October 29, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants