Repository navigation
Fix test_mnn_graph_decay and test_set_params - #90
Open
hugobuddel wants to merge 2 commits into
Open
hugobuddel wants to merge 2 commits into
hugobuddel wants to merge 2 commits into
Conversation
sklearn.utils.extmath.randomized_svd() is numerically unstable when running multiple OpenMP threads, occassionally leading to empty sets. That is all irrelevant in an API test. A low n_landmark value is stable.
pygsp generates G using dense pandas/NumPy matrices, while graphtools uses sparse matrices, leading to small numerical differences.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_mnn_graph_decayandtest_set_paramsare numerically unstable, this P.R. fixes them.