Repository navigation
feat(update): support in-app updates on macOS and Windows portable - #1698
Open
PramudithaN wants to merge 1 commit into
Open
PramudithaN wants to merge 1 commit into
PramudithaN wants to merge 1 commit into
Conversation
- Enable in-place self updating for macOS app bundles and Windows portable distributions - Extract and validate portable zip packages with Zip Slip and traversal defenses - Extract and validate macOS app bundles preserving permissions and signatures - Implement detached background helpers for safe process shutdown, file replacement, and restart - Add comprehensive unit tests covering target detection, archive extraction, and update flows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Enables in-app updates to download and install in-place directly inside the app for macOS app bundles (
Filee.app) and Windows Portable distributions (win-Portable.zip,win-arm64-Portable.zip), removing the need to redirect users to external browser download pages.update-portable.ps1) while preserving user settings (data/) andfilee.portablemarker..appbundle, verifies SHA-256 and checksum signature (.sig), extracts the new payload, and swaps bundles via a detached helper using/usr/bin/ditto(preserving signatures and bundle metadata), clears quarantine attributes, updates the CLI symlink, and restarts with automatic rollback on error.UpdateTextsandUpdateNoticeWindowto present the "Update" button (update.install) across all self-updating platforms.Type of change
How was it tested?
tests/Filee.App.Tests/UpdateServiceTests.cs:Mac_takes_its_own_files_next_to_windows_and_linux_builds(osx-arm64,osx-x64)Windows_portable_takes_portable_zip_and_shared_windows_checksums(win-portable,win-arm64-portable)The_macos_target_follows_the_process_architecture(GetMacOsRid)GetMacAppBundlePath_locates_bundle_from_nested_or_direct_pathExtractZipArchive_valid_payload_extracts_and_returns_folderExtractZipArchive_nested_payload_extracts_and_returns_nested_folderExtractZipArchive_rejects_path_traversal(Zip Slip defense)ExtractZipArchive_rejects_missing_filee_exeExtractMacArchive_valid_payload_extracts_and_returns_app_bundleExtractMacArchive_rejects_missing_executableUpdateAsync_on_windows_portable_downloads_extracts_and_spawns_powershell_helperUpdateAsync_on_windows_portable_handles_helper_start_failureUpdateAsync_on_macos_downloads_extracts_and_delegates_to_detached_helperUpdateAsync_on_macos_handles_helper_start_failureScreenshots (UI changes)
N/A (Uses existing in-app update progress modal and notification components)
Checklist
src/Filee.App/Assets/i18n/*.jsonfiles (reused existingupdate.install/update.notice_text)THIRD-PARTY-NOTICES.md(no external dependencies added)