Skip to content

feat(home): remove one conversion from Recent conversions - #1691

Open
XXingmfy wants to merge 1 commit into
KnifeLemon:mainfrom
XXingmfy:fix/1678-remove-recent-conversion
Open

XXingmfy wants to merge 1 commit into
KnifeLemon:mainfrom
XXingmfy:fix/1678-remove-recent-conversion

Conversation

@XXingmfy

@XXingmfy XXingmfy commented Nov 19, 2026 •

Copy link
Copy Markdown

What does this change?

Adds a small x button to each Recent conversions card on the Home page that forgets only that one entry, leaving its source and converted files where they are. Clear still removes the whole history.

  • UserDataStore.RemoveHistory(entry) removes the entry, writes history.json and raises HistoryChanged; it returns false and writes nothing when the entry is not present.
  • HistoryItemViewModel.RemoveFromHistoryCommand is bound to the new card button; the list refreshes through the existing HistoryChanged -> Reload() path.
  • The button sits top-right on every card, including ones without outputs (failed attempts), so those can be removed too.

Fixes #1678

Type of change

  • Bug fix
  • New feature or improvement
  • New format or engine
  • Translation
  • Documentation
  • Build, CI or dependencies

How was it tested?

  • dotnet format --verify-no-changes (the four changed C# files: 0 issues)
  • dotnet test:
    • Filee.Core.Tests -> UserDataStoreTests: 102 passed, 0 failed
    • Filee.App.Tests -> RecentConversionTests + LocalizationTests: 253 passed, 0 failed
  • New tests:
    • Core: removes only the chosen entry, keeps and persists the rest, and a second removal returns false without changing anything.
    • App: through the view model the entry disappears, the produced file stays on disk, and the change is saved for the next run.
  • Tried it in the app (Windows 11, this branch's debug build): the x shows on each card, removes that row, files stay. The Home page render test output was checked in English/Russian/Hindi/Spanish, light and dark.

Checklist

  • New UI strings are in all src/Filee.App/Assets/i18n/*.json files (one new key home.remove_from_history in all 23 catalogs; key-parity, no-empty and no-duplicate tests pass)
  • New third-party code or binaries are listed in THIRD-PARTY-NOTICES.md (none added)
  • The PR does one thing (unrelated changes go in a separate PR)

Screenshots (UI changes)

The x on each Recent conversions card (English, light theme; the Home page render test also produced Russian, Hindi and Spanish, light and dark):

Home page Recent conversions with the remove button

…#1678)

Adds a small x button to each Recent conversions card that forgets only that entry, leaving its source and converted files where they are. Clear still removes the whole history.

- UserDataStore.RemoveHistory(entry) persists the change and raises HistoryChanged.
- HistoryItemViewModel.RemoveFromHistoryCommand is bound to the card's new button.
- The button shows top-right on every card (with or without outputs) and its tooltip/automation name is the new home.remove_from_history string, added to all 23 catalogs.
- Tests: Core store test (removes one, keeps others, persists) and an App test through the view model (the file stays, the entry is saved away).
@XXingmfy
XXingmfy requested a review from KnifeLemon as a code owner November 19, 2026 06:05
@github-actions github-actions Bot added the feature New features label Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Remove individual items from recent conversions

1 participant