Repository navigation
Conversation
…#1678) Adds a small x button to each Recent conversions card that forgets only that entry, leaving its source and converted files where they are. Clear still removes the whole history. - UserDataStore.RemoveHistory(entry) persists the change and raises HistoryChanged. - HistoryItemViewModel.RemoveFromHistoryCommand is bound to the card's new button. - The button shows top-right on every card (with or without outputs) and its tooltip/automation name is the new home.remove_from_history string, added to all 23 catalogs. - Tests: Core store test (removes one, keeps others, persists) and an App test through the view model (the file stays, the entry is saved away).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds a small x button to each Recent conversions card on the Home page that forgets only that one entry, leaving its source and converted files where they are. Clear still removes the whole history.
UserDataStore.RemoveHistory(entry)removes the entry, writeshistory.jsonand raisesHistoryChanged; it returnsfalseand writes nothing when the entry is not present.HistoryItemViewModel.RemoveFromHistoryCommandis bound to the new card button; the list refreshes through the existingHistoryChanged -> Reload()path.Fixes #1678
Type of change
How was it tested?
dotnet format --verify-no-changes(the four changed C# files: 0 issues)dotnet test:Filee.Core.Tests->UserDataStoreTests: 102 passed, 0 failedFilee.App.Tests->RecentConversionTests+LocalizationTests: 253 passed, 0 failedfalsewithout changing anything.Checklist
src/Filee.App/Assets/i18n/*.jsonfiles (one new keyhome.remove_from_historyin all 23 catalogs; key-parity, no-empty and no-duplicate tests pass)THIRD-PARTY-NOTICES.md(none added)Screenshots (UI changes)
The x on each Recent conversions card (English, light theme; the Home page render test also produced Russian, Hindi and Spanish, light and dark):