Repository navigation
fix(toolbar): show the focus ring only for keyboard use - #1689
Open
adnan-bhaldar wants to merge 2 commits into
Open
adnan-bhaldar wants to merge 2 commits into
adnan-bhaldar wants to merge 2 commits into
Conversation
After clicking Edit Donut Size or Done on the Toolbar page, the page hands the keyboard focus to the button that takes its place (KeepFocus). It did so with NavigationMethod.Tab, so the focus ring was drawn even though the user had used the mouse. Remember whether the last input was a key press or a click, and give the focus with NavigationMethod.Pointer after a click, so no ring is drawn. After a key press it is still given with Tab, so keyboard users see the ring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tip
Start the title with a prefix so the PR is labeled automatically:
feat:fix:docs:ci:build:i18n:Example:
fix(hwp): keep tables when converting to DOCXWhat does this change?
KeepFocusgives focus withNavigationMethod.Pointerafter a click, and withNavigationMethod.Tabafter a key press.Why was it changed?
NavigationMethod.Tab, so Avalonia drew the focus ring on the button after a mouse click too.Type of change
How was it tested?
dotnet format --verify-no-changesdotnet testChecklist
src/Filee.App/Assets/i18n/*.jsonfiles (no new strings)THIRD-PARTY-NOTICES.md(none added)