Skip to content

Built-in engines W22: Print Studio without LibreOffice, renderer left-out notice - #1679

Merged
KnifeLemon merged 5 commits into
builtin-enginesfrom
p4/w22
Nov 19, 2026
Merged

KnifeLemon merged 5 commits into
builtin-enginesfrom
p4/w22

Conversation

@KnifeLemon

Copy link
Copy Markdown
Owner

Built-in engines wave W22: the Spreadsheet Print Studio without LibreOffice (#1392), and a notice when the renderer leaves something out (#356).

Spreadsheet Print Studio on the built-in sheet printer (#1392)

  • Preview and PDF export go through the built-in sheet printer (SheetPrintConverter), as spreadsheet → PDF already does. LibreOffice is used only when "Use LibreOffice for spreadsheets → PDF" is on and it's installed; no new setting.
  • Workbooks with things the built-in printer can't draw yet (charts, text in shapes, form controls) go to LibreOffice when it's there, as in normal conversions; otherwise they print with the existing "objects left out" notice, shown under Page setup in the studio.
  • Every studio option maps onto the built-in page setup: 6 paper sizes, orientation, scale / fit to pages, margins, page order, print area, hidden rows and columns, manual page breaks, sheet and range choice. Gridlines, headings, centring and headers/footers are not studio options and keep the sheet's own values.
  • PresetAvailability: the tool is offered for XLSX when sheet-print is there.
  • The thumbnail strip is virtualised: only visible pages render (about 7 of an 89-page sheet).
  • A workbook refused by the limits now shows the reason, not "conversion failed".

The renderer says what it left out (#356)

  • When the Filee renderer draws Word (DOCX, and DOC/WPS through it), ODT or HWP/HWPX and leaves something out or approximates it, the file's result carries a notice through the existing notice line (toast and CLI). It appears whether the renderer was the only route or the user chose it.
  • Counted while reading (HDocument.LeftOut), so no second parse. Left out: charts, SmartArt, embedded objects without a picture, ODT form controls, HWPX videos. Approximated: OLE/ODF objects drawn from their saved pictures, ODT formulas as plain text, vertical text set horizontally.
  • Each kind once with its count, left-out first, at most 4 kinds then "and more". Word/ODT without LibreOffice add "Install LibreOffice in Settings → Engines for a faithful copy" (not HWP/HWPX: LibreOffice can't read HWPX).
  • The toast's notice line now scrolls (MaxHeight 96) like the error list, so one long notice doesn't hide the others.
  • 19 keys in all 23 locales, translated.

Checks

  • New tests: SpreadsheetPrintStudioMappingTests (4), RendererLeftOutTests (5), LeftOutNoticeTests (3), LeftOutToastTests (4), plus a ToolbarEditorTests case. Inputs built in code.
  • Filtered runs on the merged wave branch: Core 405 passed, Engines 167 passed, App 319 passed (1 skipped each: LibreOffice-only). dotnet format --severity warn clean on App, Core, Engines.
  • Two studio tests that skipped without LibreOffice now run on the built-in printer and pass. The LibreOffice route itself wasn't run locally (not installed here).

Follow-ups went on the board (vertical text boxes and legacy form fields/ActiveX in the notice, ODT charts counted as charts, slides, header charts counted per section, an engine caption on the studio preview).

🤖 Generated with Claude Code

KnifeLemon and others added 4 commits November 19, 2026 08:43
When the Filee renderer converts a Word, ODT, HWP or HWPX document with
things it can't draw faithfully (no other route, or the user's choice),
the file's result now names them: charts, SmartArt, embedded objects
left out or drawn from their saved pictures, form controls, videos,
formulas written as text and vertical text set horizontally. Each kind
is listed once with its count, at most four, and Word/ODT files get
"install LibreOffice in Settings → Engines" when it isn't there.

The readers count these as they read (HDocument.LeftOut), so there is
no second look through the file. The note travels through a new
ConversionStep.LeftOut callback to FileResult.LeftOut and is shown with
the file's other notes (toast, CLI). The toast's notes line scrolls
instead of being cut at four lines.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Spreadsheet Print Studio previewed and exported only through
LibreOffice. It now prints each region's prepared copy with Filee's own
sheet printer, like every other spreadsheet to PDF; LibreOffice is used
when "Use LibreOffice for spreadsheets to PDF" is on and it is installed,
and, as in a conversion, for workbooks with objects the printer doesn't
draw yet. Without LibreOffice the studio shows the printer's notice about
what was left out.

- Every studio option (paper, orientation, scale or fit to pages,
  margins, page order, print area, hidden rows and columns, manual
  breaks, sheet choice) reaches the printer's page setup; the sheet's
  gridlines, headings, centring and headers/footers are kept.
- Refused workbooks show the usual reasoned error.
- The page strip is virtualised and renders only the thumbnails in view.
- The tool is offered for XLSX without LibreOffice.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@KnifeLemon KnifeLemon added the built-in engines Filee: built-in engines (Project 4), on the builtin-engines branch, not released yet label Nov 18, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@KnifeLemon
KnifeLemon merged commit 7d6c81f into builtin-engines Nov 19, 2026
21 of 22 checks passed
adnan-bhaldar pushed a commit to adnan-bhaldar/Filee that referenced this pull request Nov 19, 2026
… and retries

The metadata job hit its 30-minute limit on KnifeLemon#1663, KnifeLemon#1669, KnifeLemon#1671, KnifeLemon#1672 and KnifeLemon#1679: apt took 23-30 minutes to
install Ubuntu's FFmpeg. Skip the runner's man-db index rebuild, skip recommends, give apt network timeouts and
three attempts, and limit the step to 12 minutes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

built-in engines Filee: built-in engines (Project 4), on the builtin-engines branch, not released yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant