Skip to content

chore(VolumeMapperLightAndShadow): fix example - #3590

Merged
finetjul merged 1 commit into
Kitware:masterfrom
Jo-Byr:fix-volume-mapper-light-and-shadow-example
Aug 17, 2026
Merged

chore(VolumeMapperLightAndShadow): fix example#3590
finetjul merged 1 commit into
Kitware:masterfrom
Jo-Byr:fix-volume-mapper-light-and-shadow-example

Conversation

@Jo-Byr

@Jo-Byr Jo-Byr commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Context

VolumeMapperLightAndShadow's example fails to run

Results

The example is correctly usable

Some parameters were also changed so that the sliders' modification are more perceptible

Changes

Replaced missing data
Fixed GUI parameters initialization

  • Documentation and TypeScript definitions were updated to match those changes

@Jo-Byr Jo-Byr self-assigned this Jul 28, 2026
Comment thread Examples/Volume/VolumeMapperLightAndShadow/index.js Outdated
@Jo-Byr
Jo-Byr force-pushed the fix-volume-mapper-light-and-shadow-example branch from b495b28 to aa2f43c Compare August 17, 2026 09:15
Comment thread Examples/Volume/VolumeMapperLightAndShadow/index.js
Replace missing data
Fix GUI parameters initialization
@Jo-Byr
Jo-Byr force-pushed the fix-volume-mapper-light-and-shadow-example branch from aa2f43c to c1428f3 Compare August 17, 2026 11:09

@finetjul finetjul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@finetjul
finetjul added this pull request to the merge queue Aug 17, 2026
Merged via the queue into Kitware:master with commit f142087 Aug 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants