Skip to content

AV1: add new sample and fix the display of this sample - #250

Merged
dabrain34 merged 3 commits into
KhronosGroup:mainfrom
dabrain34:dab_add_new_av1_sample
Sep 29, 2026
Merged

dabrain34 merged 3 commits into
KhronosGroup:mainfrom
dabrain34:dab_add_new_av1_sample

Conversation

@dabrain34

@dabrain34 dabrain34 commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Description

A new sample named video/av1/av1-bbb-1280x720-60f.mp4 has been added to demonstrate a parser issue leading to decoding issue with nvidia driver on both Windows and Linux.

The decode is still failing with AMD on Windows, see #251

Screenshot from 2026-09-25 12-57-13

Type of change

bug fix

Issue (optional)

Tests

Intel(R) Iris(R) Xe Graphics (ADL GT2) (8086:46a6) / Intel open-source Mesa driver Mesa 26.3.0-devel (git-48126c4905) / Ubuntu 24.04.5 LTS

Total Tests: 86
Passed: 59
Crashed: 0
Failed: 0
Not Supported: 24
Skipped: 3 (in skip list)
Success Rate: 100.0%

Additional Details (optional)

Comment thread tests/decode_samples.json Outdated
Comment thread vk_video_decoder/libs/NvVideoParser/src/VulkanAV1Decoder.cpp Outdated
@dabrain34
dabrain34 force-pushed the dab_add_new_av1_sample branch 2 times, most recently from 321f47f to 1000a59 Compare September 29, 2026 07:58
t-boiko and others added 3 commits September 29, 2026 10:10
AV1 ParseByteStream memcpy'd each new frame onto the same mapped buffer while
a prior picture's shared_ptr still fed in-flight vkCmdDecodeVideoKHR
(VIDEO_DECODE_READ). That host WAR emptied OPTIMAL/LINEAR under async multi-
frame dump; H.264/VP9 already swapped buffers. Match their GetBitstreamBuffer
pattern so each decode keeps stable bitstream bytes until completion.

Signed-off-by: Tymur Boiko <tboiko@nvidia.com>
…per frame

As the VP9 parser, the requested buffer might be greater than the
previous one, so try to rezise it if it is expected instead of failing
silently.
@dabrain34
dabrain34 force-pushed the dab_add_new_av1_sample branch 2 times, most recently from ed9247c to f6a3e53 Compare September 29, 2026 08:53

@crmurillo crmurillo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@dabrain34
dabrain34 merged commit f950db0 into KhronosGroup:main Sep 29, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants