Repository navigation
Conversation
unp1
self-requested a review
November 6, 2026 09:34
unp1
reviewed
Nov 7, 2026
unp1
left a comment
unp1
left a comment
Member
There was a problem hiding this comment.
Thanks! Just a few questions to clarify before approval. Nothing major.
| in the implicit heap (additional non-object values may also be part of the domain). This can be used | ||
| in a JML specification as an invariant to ensure, that non-created objects are not (yet) part | ||
| of the domain of a map. */ | ||
| pmapInDomainImpliesCreated<K, V>(PMap<K, V>); |
Member
There was a problem hiding this comment.
That function should either be removed or it needs a heap parameter
|
|
||
| // Added by Kai Wallisch | ||
| defPMapEquality { | ||
| \find(m0 = m1) |
Member
There was a problem hiding this comment.
Is that consistent with the parameteric sorts: m1:Map<Integer, String>, m2:map<Integer, Object> if theyr are siblings in the type hierarchy the equality we could derive false, otherwise using the axiom true (if they contain the same key value pairs). How do we define the type hierarchy here?
| \find(pmapIsFinite<K, V>(pmapEmpty<K, V>)) | ||
| \replacewith(true) | ||
| \heuristics(simplify) | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intended Change
Similar to
PSeqI also see a need for maps, so I parameterizedMapto getPMap. The rules are almost exactly the same as for map, with the exception of thepmapIsFiniteaxiom, which needed strengthening. I also proved the lemmas for pmap.Whether we can/should carry over the axiom change and the proofs to
Mapshould be discussed.Type of pull request
Ensuring quality
Additional information and contact(s)
The contributions within this pull request are licensed under GPLv2, or (at your option) any later version, for inclusion in KeY.