Repository navigation
Conversation
wadoon
changed the title
wadoon
changed the title
Co-Authored-By: OpenCode (KIT Medium)
Co-Authored-By: OpenCode (KIT Medium)
Untruncated full rebuild of the fully integrated tree (pass 1 + pass 2): 606 warnings in 193 files remain, all in files outside the workstream ownership lists (deprecation 240, serial 189, this-escape 83, unchecked 64, rawtypes 25, cast 3, overrides 2). All 284 owned files (214 pass-1 + 70 pass-2) are warning-free in this run. Co-Authored-By: OpenCode (KIT Medium)
wadoon
force-pushed
the
weigl/cw-2-deprecation
branch
from
October 25, 2026 00:57
42b18d1 to
51a8e0b
Compare
wadoon
force-pushed
the
weigl/cw-2-core-misc
branch
from
October 25, 2026 00:57
ace643e to
1682f51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pass 2 of the compiler-warning cleanup. This branch originally resolved
34 javac lint warnings (14× unchecked, 10× try, 7× this-escape,
2× rawtypes, 1× cast) in 13 key.core rule/proof classes and tests
(plus the warning-inventory refresh).
Per the campaign cleanup decision, ALL serial and this-escape fixes were
REMOVED from history, so what remains is:
OneStepSimplifierRuleAppcleanly fixed byparameterizing
extends DefaultBuiltInRuleApp<BuiltInRule>(raw-superclassAbstractLDT,TestSchemaModalOperators(one shared suppressed helper) method-scopesuppressions;
TacletandBuiltInRuleclass-level@SuppressWarnings({"unchecked","rawtypes"})— a fully genericTaclet.getExecutor()is not viable (breaks javac target-type inferenceat ~40 call sites, reproduced minimally), and method-scope suppression does
not silence unchecked-override warnings (verified empirically).
handles (
proof.suspendNonEssentialListeners()—close()is the effect)→
@SuppressWarnings("try"); test semantics unchanged.(WakeKey)cast removed.3 commits total (head
1682f51163).Removed in this cleanup: the separate this-escape commit (8
constructor-level suppressions in
Node,Statistics,ProgramVariable,KeYJavaType,LongLiteral) was dropped from history entirely — thosewarnings return to baseline.
Verification
History was rebuilt by re-parenting the three surviving commits onto the
rewritten
cw-2-deprecationbase and dropping the this-escape commit: apattern scan over the rewritten history's Java diffs (
serialVersionUID,@Serial,"this-escape","serial",transient) is clean, and the keptcommits' content is byte-identical to the originals (old vs. new head diff
over the 9 touched files is empty). No behavioral changes.
Draft — part of the warning-cleanup stack (pass 2; bases cw-2-deprecation,
ultimately targeting #4001). No test-assertion or logic changes.
Commits carry
Co-Authored-By: OpenCode (KIT Medium).