Repository navigation
Conversation
…eArray API Co-Authored-By: OpenCode (KIT Medium)
…nd to ImmutableArray Co-Authored-By: OpenCode (KIT Medium)
…JavaService Co-Authored-By: OpenCode (KIT Medium)
…r and ImmutableArray Co-Authored-By: OpenCode (KIT Medium)
wadoon
force-pushed
the
weigl/cw-2-deprecation
branch
from
October 25, 2026 00:57
42b18d1 to
51a8e0b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pass 2 of the compiler-warning cleanup. This branch originally resolved the
90 javac lint warnings (84× deprecation, 3× this-escape, 2× rawtypes,
1× unchecked; 94 sites found in this worktree) in 20 key.core files — the
prover-core classes bound to the deprecated
ImmutableArrayAPI.Per the campaign cleanup decision, ALL serial and this-escape fixes were
REMOVED from history, so what remains is:
@SuppressWarnings("deprecation")witha one-line rationale per site, in the prover-core classes bound to the
deprecated
org.key_project.util.collection.ImmutableArrayAPI (successorImmutableList). These classes exposeImmutableArrayinpublic/protected signatures, fields and ctor parameters consumed across
key.core/key.ncore and the tests — swapping the runtime type is not
locally provably behavior-preserving, so the agreed policy applies
(TermFactory 20, StatementBlock 13, ClashFreeSubst 12,
JAbstractSortedOperator 9, Operator 8, Throws 6, …).
(ClashFreeSubst, OneStepSimplifier, TacletApp).
ScriptLineParser/NamespaceSet/ImmutableArrayexercised deliberately — suppressed at method scope.
4 commits total (head
51a8e0b3ef).Verification
History was rebuilt by re-writing the offending commits without the
this-escape content: the 3
@SuppressWarnings("this-escape")annotations onthe
StatementBlockctors were removed (a per-commit pattern scan over therewritten history for
serialVersionUID,@Serial,"this-escape","serial",transientis clean), andgit diffof the old vs. new branchheads over the 20 touched files shows only those 6 removed lines — every other
warning fix (deprecation, rawtypes, unchecked) is kept exactly as-is. No
behavioral changes.
Draft — part of the warning-cleanup stack (pass 2; bases cw-2-ui, ultimately
targeting #4001).
Commits carry
Co-Authored-By: OpenCode (KIT Medium).