Repository navigation
Conversation
wadoon
changed the title
wadoon
changed the title
wadoon
changed the title
… in key.ui GUI core Fix the remaining non-serial/this-escape lint warnings in WindowUserInterfaceControl: suppress the unchecked ApplyStrategyInfo cast and two GeneralFailureEvent deprecations, and demote a javadoc comment that documents a commented-out method. Co-Authored-By: OpenCode (KIT Medium)
Suppress the GeneralFailureEvent deprecation in ProofManagementAction; migrating to IssueDialog would bypass the configurable NotificationManager pipeline. Co-Authored-By: OpenCode (KIT Medium)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This branch originally resolved 100 javac lint warnings in key.ui GUI
classes — 61× serial, 34× this-escape, 3× deprecation, 1× unchecked,
1× dangling-doc-comments — as pass 2 of the compiler-warning cleanup.
Per the campaign cleanup decision, ALL serial and this-escape fixes were
REMOVED from history, so what remains is:
GeneralFailureEventsuppressions with rationalecomments, in
WindowUserInterfaceControl(saveProof,saveProofBundle) andProofManagementAction.showProofManagement—migrating to the successor
IssueDialogwould bypass the configurableNotificationManager/tasks notification pipeline (behavior change).ApplyStrategyInfocast in the GUI core(
WindowUserInterfaceControl.taskFinishedInternal) with its rationalecomment ("only an ApplyStrategyInfo for ProverCore sources; cast is safe").
WindowUserInterfaceControldemotes a/**-style comment that documents an outer (commented-out) declaration toa plain
/*comment sojavacno longer warns about it.2 commits total (head
1ad83f57eb).Verification
History was rebuilt by re-writing the two original commits without the
serial/this-escape content: a pattern scan over the rewritten commits' Java
diffs (
serialVersionUID,@Serial,"this-escape","serial",transient) is clean, andgit diffof the old vs. new branch heads showsonly removals of campaign serial/this-escape content plus restorations of the
base tree. All other warning fixes (deprecation, unchecked, dangling doc
comment) are kept exactly as-is. No behavioral changes.
Commits carry
Co-Authored-By: OpenCode (KIT Medium).