Repository navigation
Conversation
wadoon
changed the title
javac 25's auxiliaryclass lint fires on references to non-public top-level classes from other source files. Keep the references legal where required, drop them where not: - AbstractSMTTranslator: pass predicate-name StringBuilders instead of SortWrapper helper parameters (auxiliary class of SortHierarchy.java); keep class-level suppression for in-body uses. - SolverTimeout: re-type Session field/constructor parameter to Object (Session is an auxiliary class of SolverLauncher.java; the single caller always passes a Session) and cast at the use site. - JavaCardDLStrategy: qualify constant references and drop the static imports (import positions are not suppression-eligible). - GenericTranslator: type the pool as AssumptionGenerator (the public interface implementor) instead of auxiliary VariablePool. - KeyboardTacletTest: suppress with an explanatory comment. Co-Authored-By: OpenCode (KIT Medium)
Remove casts that javac flags as redundant (no behavior change): - CompiledMatchProgramBenchmark, CompiledMatchProgramTest - Filenames (key.util) - ImmutableList (key.util) Co-Authored-By: OpenCode (KIT Medium)
javac 25 treats lines with a leading third slash as part of a doc comment; replace such malformed delimiters with plain comments so no text is silently dropped or attached to the preceding javadoc. Affects MethodResolutionTest, TestNamingInvariants, SemisequentChangeInfo, Pair and CheckerData. Co-Authored-By: OpenCode (KIT Medium)
- DataRecordingTable: narrow close() from AutoCloseable to Closeable, which lets RuleIndependentData (whose only resource is a DataRecordingTable) drop its try-with-resources suppression too. - TestCopyingReplayer: suppress the resource-related warning where the managed resource intentionally outlives the method. Co-Authored-By: OpenCode (KIT Medium)
Make obviously-static accesses go through the declaring class instead of an instance where the instance is merely a name for a static method (TestPosInTerm, TestTacletBuild). Co-Authored-By: OpenCode (KIT Medium)
javac 25's text-blocks lint fires when a content line is less indented than the closing delimiter. Dedent the closing triple quote to the minimum content indentation, which yields a byte-identical string (verified at runtime). Co-Authored-By: OpenCode (KIT Medium)
SumFeature's element type Feature is reifiable, so javac flags the @SafeVarargs annotation as redundant. Drop it; the varargs array is treated as final and never exposed, preserving behavior. Co-Authored-By: OpenCode (KIT Medium)
wadoon
force-pushed
the
weigl/cw-serial
branch
from
October 25, 2026 00:57
9c54f03 to
540b10a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix the remaining "misc" javac lint categories in 21 files:
auxiliaryclass(15),
cast(4),dangling-doc-comments(5),try(4),static(3),text-blocks(1),varargs(1). 7 commits, one per category.Strategy
all fixed directly (redundant cast removed, doc comment attached, empty
try-with-resources narrowed,
instance.Static→Class.Static,@SafeVarargs).AbstractSMTTranslator: helper paramSortWrapper→ predicate-nameStringBuilder;GenericTranslator:VariablePool→AssumptionGenerator(publicimplementor, sole call site), class-level suppression then removed;
SolverTimeout: field/ctor paramSession→Objectwith aloud-failure cast at the single use site — the one non-type-safe
change, documented in the workstream report; the remaining 7 keep
class-level suppressions (javac 25 auxiliaryclass Enter-phase
regression, JDK-8354216).
Draft — part of the warning-cleanup stack (
gh stack#4010, base PR #4004,ultimately targeting #4001). No test/logic changes.
Commits carry
Co-Authored-By: OpenCode (KIT Medium).History audit (serial/this-escape)
Audited for the campaign cleanup: this branch contains NO serial or
this-escape fixes (no serialVersionUID, transient or serial/this-escape
suppressions anywhere in its 7 commits) — nothing to remove; history
unchanged, head f1985dd.
Linear-stack head:
ae411b5de3(re-based on the rebuilt #4004).