Skip to content

Leftover deprecation and rawtypes fixes from the serial workstream (stacked on #4007) - #4008

Closed
wadoon wants to merge 3 commits into
weigl/cw-deprecation-mainfrom
weigl/cw-serial
Closed

wadoon wants to merge 3 commits into
weigl/cw-deprecation-mainfrom
weigl/cw-serial

Conversation

@wadoon

@wadoon wadoon commented Oct 24, 2026 •

Copy link
Copy Markdown
Member

What

This branch originally fixed 239 [serial] warnings in 80 files. Per the
campaign cleanup decision, ALL serial and this-escape fixes were REMOVED from
history:

  • 2 serial/this-escape-only commits dropped;
  • 3 mixed commits reduced, and now contain only:
    • commit 1: deprecation suppressions + (EvictingMap<K, V>[]) cast fix in
      ncore/util exceptions/collections;
    • commit 2: raw-type array fix in StatisticsFile;
    • commit 3: rawtypes/cast/Class<?>[]/PIO_age hashCode fixes in key.ui.

No serialVersionUID, transient or serial/this-escape suppression remains in
the branch range. 3 commits total.

Verification

History pattern-scan over the rebuilt range (serialVersionUID, @Serial,
this-escape, serial, transient) is clean; the removals are the only
differences against the base plus the kept changes.

Draft — part of the warning-cleanup stack (gh stack #4010, base PR #4004,
ultimately targeting #4001). No behavioral changes.

Commits carry Co-Authored-By: OpenCode (KIT Medium).

Linear-stack head: 540b10a828 (re-based on the rebuilt #4004).

@wadoon
wadoon added this pull request to stack #4010 October 24, 2026 22:26
@wadoon wadoon changed the title weigl/cw serial Fix serial javac lint warnings (serialVersionUID, key.ui/key.core/keyext.*) Oct 24, 2026
@wadoon
wadoon removed this pull request from stack #4010 October 24, 2026 22:40
@wadoon
wadoon added this pull request to stack #4014 October 24, 2026 23:13
@wadoon wadoon changed the title Fix serial javac lint warnings (serialVersionUID, key.ui/key.core/keyext.*) Leftover deprecation and rawtypes fixes from the serial workstream (stacked on #4007) Oct 25, 2026
Add serialVersionUID to serializable exceptions and immutable collections,
mark non-serializable data fields (or suppress where transient would lose
serialized data), and remove raw-type array creations.

Co-Authored-By: OpenCode (KIT Medium)
Add serialVersionUID, mark serializable helper state transient, rename
non-hook writeObject/readObject helpers, and type the statistics array
creation explicitly.

Co-Authored-By: OpenCode (KIT Medium)
Add serialVersionUID and transient modifiers to non-serializable UI state,
suppress deliberate this-escape/deprecation usages with explanations,
drop redundant casts, and add the missing hashCode to PIO_age.

Co-Authored-By: OpenCode (KIT Medium)
@wadoon
wadoon force-pushed the weigl/cw-deprecation-main branch from 541e17d to 7299256 Compare October 25, 2026 00:57
@wadoon
wadoon deleted the branch weigl/cw-deprecation-main October 25, 2026 02:33
@wadoon wadoon closed this Oct 25, 2026
@wadoon
wadoon deleted the weigl/cw-serial branch October 25, 2026 02:33
@wadoon
wadoon removed this pull request from stack #4014 October 26, 2026 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant