Skip to content

Fix unchecked and rawtypes javac lint warnings - #4006

Closed
wadoon wants to merge 8 commits into
weigl/cw-this-escapefrom
weigl/cw-unchecked-rawtypes
Closed

wadoon wants to merge 8 commits into
weigl/cw-this-escapefrom
weigl/cw-unchecked-rawtypes

Conversation

@wadoon

@wadoon wadoon commented Oct 24, 2026 •

Copy link
Copy Markdown
Member

What

Fix the javac [unchecked] (44) and [rawtypes] (17) lint warnings in 35
files across key.util, key.core, key.core.infflow, key.ncore,
key.ncore.calculus, keyext.exploration, keyext.isabelletranslation,
keyext.proofmanagement, plus a stray [overrides]/[cast]. 8 commits, one
per module.

Strategy

  • rawtypes: exact type argument (or Foo<?>) when trivially correct — 10
    fixed; else @SuppressWarnings("rawtypes") at the narrowest scope.
  • unchecked: @SuppressWarnings("unchecked") at method/field scope — 8
    fixed / 36 suppressed; no safety-weakening wildcarding, cast runtime
    behavior unchanged.
  • overrides: missing @Override added (WeakValueLinkedHashMap gained
    hashCode() consistent with its value-only equals — standard contract
    fix, no callers rely on it).
  • Class-level suppressions (4 files incl. TestApplyTaclet): required for
    "implements <T> method in Interface"-style unchecked overrides, which
    javac provably does not silence at method/field scope; each carries an
    inline rationale. TestApplyTaclet alone has 30+ raw
    getExecutor().apply sites (the incremental baseline showed only 7).

Verification

All 8 modules compile with 0 targeted warnings (full-budget javac log
-Xmaxwarns raised to surface latent sites); spotlessCheck clean.

Draft — part of the warning-cleanup stack (gh stack #4010 → base PR #4004 →
#4001). No test-assertion or logic changes.

Commits carry Co-Authored-By: OpenCode (KIT Medium).

History audit (serial/this-escape)

Audited for the campaign cleanup: this branch contains NO serial or
this-escape fixes (no serialVersionUID, transient or serial/this-escape
suppressions anywhere in its 8 commits) — nothing to remove; history
unchanged, head 9ac3cb2.

Linear-stack head: 5c28dc3602 (re-based on the rebuilt #4004).

@wadoon
wadoon changed the base branch from weigl/cleanwarnings to weigl/cw-this-escape October 24, 2026 22:26
@wadoon
wadoon added this pull request to stack #4010 October 24, 2026 22:26
@wadoon
wadoon force-pushed the weigl/cw-unchecked-rawtypes branch from 12b48da to 9ac3cb2 Compare October 24, 2026 22:31
@wadoon
wadoon removed this pull request from stack #4010 October 24, 2026 22:40
@wadoon
wadoon added this pull request to stack #4014 October 24, 2026 23:13
Co-Authored-By: OpenCode (KIT Medium)
Co-Authored-By: OpenCode (KIT Medium)
Co-Authored-By: OpenCode (KIT Medium)
Co-Authored-By: OpenCode (KIT Medium)
Co-Authored-By: OpenCode (KIT Medium)
Co-Authored-By: OpenCode (KIT Medium)
Co-Authored-By: OpenCode (KIT Medium)
@wadoon
wadoon force-pushed the weigl/cw-this-escape branch from b5d9c72 to 56ddb4c Compare October 25, 2026 00:57
@wadoon
wadoon force-pushed the weigl/cw-unchecked-rawtypes branch from 9ac3cb2 to 5c28dc3 Compare October 25, 2026 00:57
@wadoon
wadoon deleted the branch weigl/cw-this-escape October 25, 2026 02:33
@wadoon wadoon closed this Oct 25, 2026
@wadoon
wadoon deleted the weigl/cw-unchecked-rawtypes branch October 25, 2026 02:33
@wadoon
wadoon removed this pull request from stack #4014 October 26, 2026 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant