Repository navigation
Conversation
wadoon
changed the base branch from
weigl/cleanwarnings
to
weigl/cw-this-escape
October 24, 2026 22:26
wadoon
force-pushed
the
weigl/cw-unchecked-rawtypes
branch
from
October 24, 2026 22:31
12b48da to
9ac3cb2
Compare
Co-Authored-By: OpenCode (KIT Medium)
Co-Authored-By: OpenCode (KIT Medium)
Co-Authored-By: OpenCode (KIT Medium)
Co-Authored-By: OpenCode (KIT Medium)
Co-Authored-By: OpenCode (KIT Medium)
Co-Authored-By: OpenCode (KIT Medium)
Co-Authored-By: OpenCode (KIT Medium)
Co-Authored-By: OpenCode (KIT Medium)
wadoon
force-pushed
the
weigl/cw-this-escape
branch
from
October 25, 2026 00:57
b5d9c72 to
56ddb4c
Compare
wadoon
force-pushed
the
weigl/cw-unchecked-rawtypes
branch
from
October 25, 2026 00:57
9ac3cb2 to
5c28dc3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix the javac
[unchecked](44) and[rawtypes](17) lint warnings in 35files across
key.util,key.core,key.core.infflow,key.ncore,key.ncore.calculus,keyext.exploration,keyext.isabelletranslation,keyext.proofmanagement, plus a stray[overrides]/[cast]. 8 commits, oneper module.
Strategy
Foo<?>) when trivially correct — 10fixed; else
@SuppressWarnings("rawtypes")at the narrowest scope.@SuppressWarnings("unchecked")at method/field scope — 8fixed / 36 suppressed; no safety-weakening wildcarding, cast runtime
behavior unchanged.
@Overrideadded (WeakValueLinkedHashMapgainedhashCode()consistent with its value-onlyequals— standard contractfix, no callers rely on it).
TestApplyTaclet): required for"implements
<T>method in Interface"-style unchecked overrides, whichjavac provably does not silence at method/field scope; each carries an
inline rationale.
TestApplyTacletalone has 30+ rawgetExecutor().applysites (the incremental baseline showed only 7).Verification
All 8 modules compile with 0 targeted warnings (full-budget javac log
-Xmaxwarnsraised to surface latent sites);spotlessCheckclean.Draft — part of the warning-cleanup stack (
gh stack#4010 → base PR #4004 →#4001). No test-assertion or logic changes.
Commits carry
Co-Authored-By: OpenCode (KIT Medium).History audit (serial/this-escape)
Audited for the campaign cleanup: this branch contains NO serial or
this-escape fixes (no serialVersionUID, transient or serial/this-escape
suppressions anywhere in its 8 commits) — nothing to remove; history
unchanged, head 9ac3cb2.
Linear-stack head:
5c28dc3602(re-based on the rebuilt #4004).