Skip to content

Support default include files + minor run clean-up - #456

Merged
pehrsoderman merged 8 commits into
Kattis:masterfrom
gkreitz:444_default_include_files
Aug 13, 2026
Merged

Support default include files + minor run clean-up#456
pehrsoderman merged 8 commits into
Kattis:masterfrom
gkreitz:444_default_include_files

Conversation

@gkreitz

@gkreitz gkreitz commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Adds support for "default" include files (using parsed model.Includes instead of having find_programs duplicate that logic).

Also a bit of clean-up of run:

  • Fix a bug in mainfile detection in model - we did not filter on source files.
  • Adds type annotations to constructors in run (they were previously in comments). This makes mypy find new things, so I stopped there to avoid blowing up this PR.
  • Stricter parameter lists for constructors and methods in run - e.g., you must now specify a workdir (instead of the classes subtly just dropping a tmp dir somewhere if you forgot).

Fixes #444

Comment thread problemtools/model/includes.py
@pehrsoderman
pehrsoderman merged commit 908aa1e into Kattis:master Aug 13, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for "default" include files

2 participants