Catch writes interrupted by exit. - #43
Open
QuzarDC wants to merge 1 commit into
Open
Conversation
The code for `recv_data` was presuming that the syscall on the DC side would continue until the data was finished. In the event of the program exiting though, if a data transfer was still in progress this would cause a somewhat cryptic "Obviously bad packet" error and dc-tool waiting for further commands that would never be received. Now, on each packet receive we test for the possibility that a CMD_EXIT was received and if so percolate up an exit code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code for
recv_datawas presuming that the syscall on the DC side would continue until the data was finished. In the event of the program exiting though, if a data transfer was still in progress this would cause a somewhat cryptic "Obviously bad packet" error and dc-tool waiting for further commands that would never be received.Now, on each packet receive we test for the possibility that a CMD_EXIT was received and if so percolate up an exit code.