Skip to content

Make a pack from an instance - #616

Merged
Maximilian-Nesslauer merged 2 commits into
mainfrom
pack-from-instance
Sep 27, 2026
Merged

Maximilian-Nesslauer merged 2 commits into
mainfrom
pack-from-instance

Conversation

@Maximilian-Nesslauer

Copy link
Copy Markdown
Member

Closes #565

  • The instance menu has "Make a pack from this instance", which opens the listing editor with a new pack of the enabled index mods of the instance at their installed versions.
  • Mod loaders, disabled mods, manual installs, mods or releases that the index does not list or has yanked, and releases whose download is gone from their host are left out, and the Members card names each one with its reason.
  • The pack name comes from the instance, and game_min is proposed from the pinned releases.

@Maximilian-Nesslauer Maximilian-Nesslauer added this to the v0.3.0 milestone Sep 26, 2026
@Maximilian-Nesslauer Maximilian-Nesslauer added area:core Borea.Core, the domain model area:app Borea.App, the Avalonia UI pack Mod packs labels Sep 26, 2026
@github-project-automation github-project-automation Bot moved this to Backlog in Borea Sep 26, 2026
@Maximilian-Nesslauer
Maximilian-Nesslauer added this pull request to stack #617 September 26, 2026 22:30
@coveralls

coveralls commented Sep 26, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 36306974017

Coverage increased (+0.002%) to 87.881%

Details

  • Coverage increased (+0.002%) from the base build.
  • Patch coverage: 13 uncovered changes across 3 files (100 of 113 lines covered, 88.5%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
src/Borea.App/ViewModels/MainViewModel.Listing.cs 17 10 58.82%
src/Borea.App/Localization/LocalizationService.cs 12 9 75.0%
src/Borea.App/ViewModels/ListingEditor.Pack.cs 45 42 93.33%
Total (8 files) 113 100 88.5%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 33771
Covered Lines: 31005
Line Coverage: 91.81%
Relevant Branches: 17100
Covered Branches: 13701
Branch Coverage: 80.12%
Branches in Coverage %: Yes
Coverage Strength: 6024.27 hits per line

💛 - Coveralls

Base automatically changed from pack-next-version to main September 27, 2026 08:41
- ListingPackFromInstance pins the enabled mods of an instance that the snapshot lists and has a stamped release of, at the installed version, in load order and with the index spelling of the id

- Every other mod is left out with one reason, checked in this order: mod loader, disabled, not listed, release not stamped, yanked

- The loaders that the mods need are left out too, with the version of the loader installation when Borea knows it

- The folders Borea did not install are left out as not installed by Borea
- The instance menu in the Library, on Home and on the instance page offers Make a pack from this instance

- The mods folder is scanned first, so a folder added or removed by hand since the last scan is named correctly

- The editor opens a new pack with the members, the name of the instance and the highest game_min of the pinned releases

- The Members card names each left-out mod with its reason, and a line goes away when the author adds that mod

- Without a content index, no pack opens and an error toast says why
@Maximilian-Nesslauer
Maximilian-Nesslauer merged commit c48cc72 into main Sep 27, 2026
10 checks passed
@Maximilian-Nesslauer
Maximilian-Nesslauer deleted the pack-from-instance branch September 27, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:app Borea.App, the Avalonia UI area:core Borea.Core, the domain model pack Mod packs

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Make a pack from an instance

3 participants