Write a pack version in the listing editor - #614
Merged
Merged
Conversation
- ListingDraft reads and writes version, released_at, changelog and mods of a modpack, keeps every key it does not name, and puts a pack at packs/<id>/<version>.toml - ListingPackMembers says which listed mods and releases a pack can pin - ListingRules counts the forums thread of every pack version for the thread note
- The first step offers a mod pack, which opens the form with a Pack and a Members section instead of Releases, Loader and Dependencies - Members are picked from the snapshot, and a pin that no client can install stays in the file with a note - The editor proposes the highest game_min of the pinned releases - A pack has no signed-in publish yet, and the browser opens its pack path, with the 2,000 character link limit
- The member picker offers only releases that are not yanked and still download (RFC 0078). - A loaded pin of a gone release stays and its note names the date, and it still counts for the game_min proposal.
Maximilian-Nesslauer
requested review from
MrJeranimo,
PlazmaBoltz,
averageksp and
renancamm
September 26, 2026 21:55
averageksp
approved these changes
Sep 26, 2026
Coverage Report for CI Build 36274583931Coverage increased (+0.007%) to 87.804%Details
Uncovered Changes
Coverage Regressions5 previously-covered lines in 3 files lost coverage.
Coverage Stats💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #563
packs/<id>/<version>.toml, and a long file is copied for pasting.