Repository navigation
Lock down /api/nlp: API key auth, rate limit, input validation - #2
Open
KARLalpha4768 wants to merge 1 commit into
Open
KARLalpha4768 wants to merge 1 commit into
KARLalpha4768 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses SEC-07.
Note: the browser client must now send X-API-Key; a key shipped in a public page is not secret, so a server-side session or proxy is a follow-up.
Verified (outside the Codex sandbox, Python 3.13.12 on Windows): python -m py_compile on every changed .py and node --check on every changed .js on this branch: 0 failures. pytest -q: 25 passed (baseline before changes: 25 passed). Secret scan: no hardcoded demo API key, Cesium-style JWT token, or postgres credentials remain once all five PRs are merged (each branch alone only removes its own items).
Not verified: docker build (Docker not available on the dev PC), terraform validate/plan, runtime/deployment tests. The existing tests do not exercise most changed code. Changes drafted with headless Codex and reviewed by hand.
One of five PRs splitting the HIGH findings from antigravity-findings-v2: fix/secrets-env, fix/api-nlp-lockdown, fix/docker-build, fix/infra-hardening, fix/correctness-high.